Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gen4] More aggregation support #10332

Merged
merged 8 commits into from
May 19, 2022
Merged

Conversation

systay
Copy link
Collaborator

@systay systay commented May 18, 2022

Description

This change makes it possible for the gen4 planner to accept aggregation functions in HAVING that are not returned to the user, such as:

select id 
from tbl 
group by id 
having count(*) > 10

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes labels May 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea! ❤️ lgtm

go/vt/vtgate/planbuilder/abstract/queryprojection.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/aggr_cases.txt Outdated Show resolved Hide resolved
@frouioui
Copy link
Member

frouioui commented May 18, 2022

It would be nice to add an end-to-end test in the /queries/aggregation package and compare the results with MySQL.

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from frouioui May 19, 2022 10:35
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/unsupported_cases.txt Outdated Show resolved Hide resolved
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 165dee2 into vitessio:main May 19, 2022
@systay systay deleted the more-aggre-support branch May 19, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants