Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gen4] More aggregation support #10332

Merged
merged 8 commits into from
May 19, 2022
Merged

[gen4] More aggregation support #10332

merged 8 commits into from
May 19, 2022

Commits on May 18, 2022

  1. refactor: move HAVING with aggregation to QP 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed May 18, 2022
    Configuration menu
    Copy the full SHA
    8312ad9 View commit details
    Browse the repository at this point in the history

  2. feat: add aggregation expressions needed by HAVING 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed May 18, 2022
    Configuration menu
    Copy the full SHA
    f19fdc7 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. test&refactor: add integration test and clean up types 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    1cfae2c View commit details
    Browse the repository at this point in the history

  2. refactor: use sort.Slice to avoid extra types 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    3df6cd3 View commit details
    Browse the repository at this point in the history

  3. feat: change the string representation of offset for better clarity 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    daace3a View commit details
    Browse the repository at this point in the history

  4. feat: handle columns with not in grouping or aggregations better 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    fe410ee View commit details
    Browse the repository at this point in the history

  5. test: update test expectations 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    69b01bf View commit details
    Browse the repository at this point in the history

  6. test refactor: move out test cases that pass from unsupported_cases 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed May 19, 2022
    Configuration menu
    Copy the full SHA
    96778ce View commit details
    Browse the repository at this point in the history