Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: Fix issue when no routes are found from a lookup #10422

Merged
merged 1 commit into from
Jun 4, 2022
Merged

v3: Fix issue when no routes are found from a lookup #10422

merged 1 commit into from
Jun 4, 2022

Conversation

systay
Copy link
Collaborator

@systay systay commented Jun 3, 2022 •
edited

Description

In a recent change (#10152), we introduced a special mode handling when no routes are found for a query.
This introduced an issue that was later fixed for gen4 (#10346), but here I missed fixing the same issue for v3.

Needs to be backported to R13 since the above changes were backported.

Related Issue(s)

#10152 Bug introduced
#10346 Bug fixed for Gen4
Fixes #10301

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@systay systay mentioned this pull request Jun 3, 2022
Closed
@systay systay force-pushed the sec-vindex branch 2 times, most recently from c10455e to 3a1a78b Compare June 3, 2022 10:39
@systay systay changed the title add test v3: Fix issue when no routes are found from a lookup Jun 3, 2022
@systay systay marked this pull request as ready for review June 3, 2022 10:47
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@systay
fix V3: only use the special NoRoute handling mode when needed
17fac7f 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit dccb07e into vitessio:main Jun 4, 2022
@systay systay deleted the sec-vindex branch June 4, 2022 05:54
harshit-gangal pushed a commit to planetscale/vitess that referenced this pull request Aug 16, 2022
@systay @harshit-gangal
fix V3: only use the special NoRoute handling mode when needed (vites…
1232ac4 
…sio#10422)

Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal harshit-gangal mentioned this pull request Aug 16, 2022
Merged
deepthi added a commit that referenced this pull request Aug 16, 2022
@harshit-gangal @systay
@arthurschreiber @evaccaro @mikrobi @deepthi
[13.0] Cherry Pick: only use the special NoRoute handling mode when n…
87c8549 
…eeded (#11020)

* fix V3: only use the special NoRoute handling mode when needed (#10422)

Signed-off-by: Andres Taylor <andres@planetscale.com>

* fix: build

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Fix failure when Unowned lookup IS NULL (#10346)

* Add a failing test case showing Gen4 planner failure.

This test case shows a regression in the query planner for queries that use `IS NULL` condition on an unowned lookup vindex column.

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Co-authored-by: Elisa Vaccaro <30807261+evaccaro@users.noreply.github.com>
Co-authored-by: Jakob Class <mikrobi@github.com>

* bugfix: Limit the use of NoRoutesSpecialHandling to when it's needed

Signed-off-by: Andres Taylor <andres@planetscale.com>

Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Co-authored-by: Elisa Vaccaro <30807261+evaccaro@users.noreply.github.com>
Co-authored-by: Jakob Class <mikrobi@github.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Co-authored-by: Elisa Vaccaro <30807261+evaccaro@users.noreply.github.com>
Co-authored-by: Jakob Class <mikrobi@github.com>
Co-authored-by: deepthi <deepthi@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: select with where in on secondary vindex is not working
3 participants
@systay @GuptaManan100 @harshit-gangal