Bug Report: select with where in on secondary vindex is not working

[L3o-pold]

Overview of the Issue

Runing where in(...) query with no sharding key on a secondary vindex (consistent_lookup_unique) is throwing an error.

select `username` from `users`  where `id` in ("test2", "test")

vttablet: rpc error: code = InvalidArgument desc = missing bind var __vals (CallerID: userData1)

Reproduction Steps

1. Deploy the following vschema:

{
   "sharded":true,
   "vindexes":{
      "unicode_loose_md5":{
         "type":"unicode_loose_md5"
      },
      "users_keyspace_id":{
         "type":"consistent_lookup_unique",
         "params":{
            "table":"commerce.users_keyspace_id",
            "from":"id",
            "to":"keyspace_id"
         },
         "owner":"users"
      }
   },
   "tables":{
      "users":{
         "column_vindexes":[
            {
               "column":"team_id",
               "name":"unicode_loose_md5"
            },
            {
               "column":"id",
               "name":"users_keyspace_id"
            }
         ]
      },
      "users_keyspace_id":{
         "column_vindexes":[
            {
               "column":"id",
               "name":"unicode_loose_md5"
            }
         ]
      }
   }
}

2. Deploy the following schema

create table users(id char(36), team_id char(36), username varchar(50), primary key(id));

3. Run the query

select `username` from `users`  where `id` in ("test2", "test")

5. View error

vttablet: rpc error: code = InvalidArgument desc = missing bind var __vals (CallerID: userData1)

Explain

Route	IN	user		UNKNOWN	select username from users where id in ::__vals

Binary Version

Version: 14.0.0-SNAPSHOT (Git revision 209c5747c529b001ad71b5f9bed53f57c6f5fdeb branch 'main') built on Tue May  3 09:53:06 UTC 2022 by vitess@buildkitsandbox using go1.18.1 linux/amd64

Operating System and Environment details

Docker

Log Fragments

No response

[aquarapid]

Confirmed. I ran into this separately.

My repro is minimal:

schema:

CREATE TABLE t1 (
        c1 bigint unsigned NOT NULL,
        c2 varchar(16) NOT NULL,
        PRIMARY KEY (c1)
) ENGINE InnoDB;

CREATE TABLE lookup_t1 (
        c2 varchar(16) NOT NULL,
        keyspace_id varbinary(16) NOT NULL,
        PRIMARY KEY (c2)
) ENGINE InnoDB;

vschema:

{
  "sharded": true,
  "vindexes": {
    "lookup_idx": {
      "type": "lookup",
      "params": {
        "from": "c2",
        "to": "keyspace_id",
        "table": "lookup_t1"
      },
      "owner": "t1"
    },
    "xxhash": {
      "type": "xxhash"
    }
  },
  "tables": {
    "t1": {
      "columnVindexes": [
        {
          "column": "c1",
          "name": "xxhash"
        },
        {
          "column": "c2",
          "name": "lookup_idx"
        }
      ]
    },
    "lookup_t1": {
      "columnVindexes": [
        {
          "column": "c2",
          "name": "xxhash"
        }
      ]
    }
  }
}

Once the vschema is applied to a sharded (2 shards) keyspace, with table t1 still empty:

mysql> select * from t1;               
Empty set (0.00 sec)

mysql> select* from t1 where c2 = "abc";
Empty set (0.01 sec)

This is OK so far. However, if I pass values (whether one or many) via an IN clause that flows via the lookup:

mysql> select* from t1 where c2 in ("abc");
ERROR 1105 (HY000): target: sharded.80-.primary: vttablet: rpc error: code = InvalidArgument desc = missing bind var __vals (CallerID: user)

mysql> select* from t1 where c2 in ("abc", "def");
ERROR 1105 (HY000): target: sharded.-80.primary: vttablet: rpc error: code = InvalidArgument desc = missing bind var __vals (CallerID: user)

That seems bad.

[systay]

I tried reproducing it locally but was not able to. created a PR to test it in CI: #10422