Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add review checklist on release-13.0 #10473

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Add review checklist on release-13.0 #10473

merged 1 commit into from
Jun 16, 2022

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Jun 8, 2022 •
edited
Loading

Description

This cherry-picks #10471 and adds the review checklist to the release-13.0 branch.

@frouioui frouioui changed the base branch from main to release-13.0 June 8, 2022 14:53
@frouioui frouioui changed the title ùBp 10471 on 13 bp 10471 on 13 Jun 8, 2022
@frouioui frouioui marked this pull request as draft June 8, 2022 14:53
@frouioui frouioui changed the title bp 10471 on 13 Add review checklist on release-13.0 Jun 8, 2022
@frouioui frouioui marked this pull request as ready for review June 8, 2022 14:56
@frouioui frouioui added the Backport This is a backport label Jun 8, 2022
ajm188
ajm188 approved these changes Jun 8, 2022
View reviewed changes
.github/workflows/comment_pull_request.yml
- [ ] Changes to `_vt` tables and RPCs need to be backward compatible.
- [ ] `vtctl` command output order should be stable and `awk`-able.

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOILI: you've got a missing newline at the end here

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@rohit-nayak-ps
Copy link
Contributor

@frouioui, DCO is missing

@frouioui @rohit-nayak-ps
Update the comment for review checklist with an item for CI workflows (…
4bbc72c 
…vitessio#10471)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Copy link
Contributor

@frouioui, DCO is missing

Amended commit with DCO and pushed

@frouioui
Copy link
Member Author

@rohit-nayak-ps, that's weird! Thank you for amending it.

@frouioui frouioui merged commit c442690 into vitessio:release-13.0 Jun 16, 2022
@frouioui frouioui deleted the bp-10471-on-13 branch June 16, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@mattlord mattlord Awaiting requested review from mattlord

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Backport This is a backport Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frouioui @rohit-nayak-ps @ajm188