Accept geomcollection as alias for geometrycollection #10641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://dev.mysql.com/doc/refman/8.0/en/spatial-type-overview.html does not mention `geomcollection` as an alias, but https://dev.mysql.com/doc/refman/8.0/en/gis-class-geometrycollection.html does describe it and it even mentions it as preferred. This preference shows in `SHOW CREATE TABLE` statements where `geomcollection` is always used as the type. We need to be able to parse that for `schemadiff` then. In a follow up we can add normalization of this to `schemadiff` which seems like a better place to match the preference then that MySQL has than in the parser which accepts now both tokens. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
added
Type: Enhancement
dbussink
requested review from
harshit-gangal,
systay and
GuptaManan100
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
mdlayher
approved these changes
Jul 6, 2022
rsajwani
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 1, 2022
vitessio#807) https://dev.mysql.com/doc/refman/8.0/en/spatial-type-overview.html does not mention `geomcollection` as an alias, but https://dev.mysql.com/doc/refman/8.0/en/gis-class-geometrycollection.html does describe it and it even mentions it as preferred. This preference shows in `SHOW CREATE TABLE` statements where `geomcollection` is always used as the type. We need to be able to parse that for `schemadiff` then. In a follow up we can add normalization of this to `schemadiff` which seems like a better place to match the preference then that MySQL has than in the parser which accepts now both tokens. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.mysql.com/doc/refman/8.0/en/spatial-type-overview.html does not mention
geomcollectionas an alias, buthttps://dev.mysql.com/doc/refman/8.0/en/gis-class-geometrycollection.html
does describe it and it even mentions it as preferred.
This preference shows in
SHOW CREATE TABLEstatements wheregeomcollectionis always used as the type. We need to be able to parse that forschemadiffthen.In a follow up we can add normalization of this to
schemadiffwhich seems like a better place to match the preference then that MySQL has than in the parser which accepts now both tokens.Related Issue(s)
#10203
Checklist