Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle info_schema routing #15899

Merged
merged 1 commit into from
May 9, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented May 9, 2024

Description

In order to handle I_S tables/views correctly, we have to do thing different than we do for normal tables.
These queries can be sent to any shard on any keyspace.

Backports

This is a relatively low-risk change to backport, so I suggest we backport it at least to v18 and v19.

Related Issue(s)

Fixes #15900

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented May 9, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 9, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 9, 2024
@systay systay added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 9, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay marked this pull request as ready for review May 9, 2024 07:35
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.46%. Comparing base (cbf89bd) to head (cf8039e).

Files Patch % Lines
go/vt/vtgate/planbuilder/vexplain.go 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15899      +/-   ##
==========================================
+ Coverage   68.43%   68.46%   +0.02%     
==========================================
  Files        1559     1559              
  Lines      196753   196763      +10     
==========================================
+ Hits       134657   134713      +56     
+ Misses      62096    62050      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay changed the title feat: handle info_schema routing fix: handle info_schema routing May 9, 2024
@systay systay added Backport to: release-17.0 Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 and removed Backport to: release-17.0 labels May 9, 2024
@harshit-gangal harshit-gangal merged commit da594ae into vitessio:main May 9, 2024
187 checks passed
@harshit-gangal harshit-gangal deleted the info_schema_other_read branch May 9, 2024 10:08
vitess-bot pushed a commit that referenced this pull request May 9, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay added a commit that referenced this pull request May 9, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui pushed a commit that referenced this pull request May 9, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
frouioui pushed a commit that referenced this pull request May 9, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andrés Taylor <andres@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Query Serving Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DESCRIBE fails for information_schema table/views
3 participants