-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle info_schema routing #15899
Merged
harshit-gangal
merged 1 commit into
vitessio:main
from
planetscale:info_schema_other_read
May 9, 2024
Merged
fix: handle info_schema routing #15899
harshit-gangal
merged 1 commit into
vitessio:main
from
planetscale:info_schema_other_read
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
May 9, 2024
systay
added
Type: Bug
Component: Query Serving
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
May 9, 2024
systay
force-pushed
the
info_schema_other_read
branch
from
May 9, 2024 07:18
85dd84f
to
1667667
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
info_schema_other_read
branch
from
May 9, 2024 07:29
1667667
to
cf8039e
Compare
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
May 9, 2024 07:35
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15899 +/- ##
==========================================
+ Coverage 68.43% 68.46% +0.02%
==========================================
Files 1559 1559
Lines 196753 196763 +10
==========================================
+ Hits 134657 134713 +56
+ Misses 62096 62050 -46 ☔ View full report in Codecov by Sentry. |
systay
changed the title
feat: handle info_schema routing
fix: handle info_schema routing
May 9, 2024
systay
added
Backport to: release-17.0
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
and removed
Backport to: release-17.0
labels
May 9, 2024
systay
force-pushed
the
info_schema_other_read
branch
from
May 9, 2024 09:15
f45e905
to
cf8039e
Compare
GuptaManan100
approved these changes
May 9, 2024
harshit-gangal
approved these changes
May 9, 2024
vitess-bot
pushed a commit
that referenced
this pull request
May 9, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
added a commit
that referenced
this pull request
May 9, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
pushed a commit
that referenced
this pull request
May 9, 2024
frouioui
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to handle
I_S
tables/views correctly, we have to do thing different than we do for normal tables.These queries can be sent to any shard on any keyspace.
Backports
This is a relatively low-risk change to backport, so I suggest we backport it at least to v18 and v19.
Related Issue(s)
Fixes #15900
Checklist