Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi table update with non literal value #15980

Merged
merged 7 commits into from
May 22, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented May 20, 2024

Description

This PR adds support for multi table update with update expression having dependency from multiple tables.

e.g. update t1, t2 set t1.col = t2.col + 2 where t1.id = t2.id and t1.foo = 2;
Here, update of t1.col is dependent on value of t2's table col

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link
Contributor

vitess-bot bot commented May 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 20, 2024
@harshit-gangal harshit-gangal changed the title feat: handle multi table update with non literal value Add support for multi table update with non literal value May 20, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 20, 2024
@harshit-gangal harshit-gangal added Type: Feature Request Component: Query Serving and removed NeedsWebsiteDocsUpdate What it says NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 20, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 80.58252% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 68.48%. Comparing base (8b60b59) to head (be4fd87).
Report is 8 commits behind head on main.

Current head be4fd87 differs from pull request most recent head 7d9d50f

Please upload reports for the commit 7d9d50f to get more accurate results.

Files Patch % Lines
go/vt/vtgate/engine/dml_with_input.go 52.38% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15980      +/-   ##
==========================================
+ Coverage   68.46%   68.48%   +0.01%     
==========================================
  Files        1562     1562              
  Lines      197059   197154      +95     
==========================================
+ Hits       134919   135016      +97     
+ Misses      62140    62138       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label May 20, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review May 20, 2024 17:40
@harshit-gangal harshit-gangal removed the NeedsIssue A linked issue is missing for this Pull Request label May 20, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

go/vt/vtgate/planbuilder/operators/update.go Outdated Show resolved Hide resolved
],
"KsidLength": 1,
"KsidVindex": "user_index",
"OwnedVindexQuery": "select Id, `Name`, Costly, `user`.`name` = :ue_id + 'foo' from `user` where `user`.id in ::dml_vals for update",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused here. Why are we using user.id in ::dml_vals when we have the :ue_id parameter available. ::dml_vals will only contain a single value here, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be changed from list argument to single argument.
It is not a problem as-is. Definitely, this can be changed

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal merged commit 2283f6b into vitessio:main May 22, 2024
91 checks passed
@harshit-gangal harshit-gangal deleted the multi-upd-nonliteral branch May 22, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for multi table update for non literal column update using other dependent table
4 participants