Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication Workflow: set state correctly when restarting workflow streams in the copy phase #16217

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

This PR fixes a bug where a workflow which has been stopped during the copy phase has its published state (observable at debug/vars set incorrectly to Running when it is restarted. We now check for tables still pending copy and update the stream state to Copying or Running based on whether we are still in the copy phase.

Backports

This issue has been around for about 15 months, so backporting to all supported versions.

Related Issue(s)

#15337

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

… and set them to Copying instead of Running

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps added Type: Bug Component: VReplication Backport to: release-17.0 Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0-rc Needs to be backport to release-20.0-rc Backport to: release-20.0 Needs to be backport to release-20.0 labels Jun 18, 2024
Copy link
Contributor

vitess-bot bot commented Jun 18, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 18, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 18, 2024
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 18, 2024
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review June 18, 2024 17:41
@rohit-nayak-ps rohit-nayak-ps requested review from mattlord and a team June 18, 2024 17:41
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.56%. Comparing base (1ffabca) to head (c8a2de5).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletmanager/rpc_vreplication.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16217      +/-   ##
==========================================
+ Coverage   68.55%   68.56%   +0.01%     
==========================================
  Files        1544     1544              
  Lines      197895   197909      +14     
==========================================
+ Hits       135658   135688      +30     
+ Misses      62237    62221      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui mentioned this pull request Jun 18, 2024
34 tasks
@frouioui frouioui merged commit 4a7ad80 into vitessio:main Jun 18, 2024
94 checks passed
@frouioui frouioui deleted the rohit/vtctldclient-set-correct-state-on-start branch June 18, 2024 18:11
vitess-bot pushed a commit that referenced this pull request Jun 18, 2024
…treams in the copy phase (#16217)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
vitess-bot pushed a commit that referenced this pull request Jun 18, 2024
…treams in the copy phase (#16217)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
shlomi-noach pushed a commit that referenced this pull request Jun 18, 2024
…ting workflow streams in the copy phase (#16217) (#16224)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
shlomi-noach pushed a commit that referenced this pull request Jun 18, 2024
…tarting workflow streams in the copy phase (#16217) (#16223)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
frouioui pushed a commit that referenced this pull request Jun 21, 2024
…ting workflow streams in the copy phase (#16217) (#16222)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
frouioui pushed a commit that referenced this pull request Jun 21, 2024
…ting workflow streams in the copy phase (#16217) (#16221)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0-rc Needs to be backport to release-20.0-rc Backport to: release-20.0 Needs to be backport to release-20.0 Component: VReplication Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants