-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication Workflow: set state correctly when restarting workflow streams in the copy phase #16217
Merged
frouioui
merged 2 commits into
vitessio:main
from
planetscale:rohit/vtctldclient-set-correct-state-on-start
Jun 18, 2024
Merged
VReplication Workflow: set state correctly when restarting workflow streams in the copy phase #16217
frouioui
merged 2 commits into
vitessio:main
from
planetscale:rohit/vtctldclient-set-correct-state-on-start
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and set them to Copying instead of Running Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
added
Type: Bug
Component: VReplication
Backport to: release-17.0
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0-rc
Needs to be backport to release-20.0-rc
Backport to: release-20.0
Needs to be backport to release-20.0
labels
Jun 18, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jun 18, 2024
rohit-nayak-ps
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jun 18, 2024
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
requested review from
deepthi,
GuptaManan100 and
shlomi-noach
as code owners
June 18, 2024 17:41
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16217 +/- ##
==========================================
+ Coverage 68.55% 68.56% +0.01%
==========================================
Files 1544 1544
Lines 197895 197909 +14
==========================================
+ Hits 135658 135688 +30
+ Misses 62237 62221 -16 ☔ View full report in Codecov by Sentry. |
shlomi-noach
approved these changes
Jun 18, 2024
frouioui
approved these changes
Jun 18, 2024
This was referenced Jun 18, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
…treams in the copy phase (#16217) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
vitess-bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
…treams in the copy phase (#16217) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-18.0
Needs to be back ported to release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0-rc
Needs to be backport to release-20.0-rc
Backport to: release-20.0
Needs to be backport to release-20.0
Component: VReplication
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where a workflow which has been stopped during the copy phase has its published state (observable at
debug/vars
set incorrectly to Running when it is restarted. We now check for tables still pending copy and update the stream state toCopying
orRunning
based on whether we are still in the copy phase.Backports
This issue has been around for about 15 months, so backporting to all supported versions.
Related Issue(s)
#15337
Checklist
Deployment Notes