feat: make the arguments print themselves with type info #16232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
dbussink
reviewed
Jun 19, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
added
Type: Enhancement
dbussink
reviewed
Jun 25, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16232 +/- ##
==========================================
+ Coverage 68.60% 68.61% +0.01%
==========================================
Files 1544 1544
Lines 198016 198065 +49
==========================================
+ Hits 135849 135903 +54
+ Misses 62167 62162 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
reviewed
Jun 26, 2024
dbussink
reviewed
Jun 26, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
|
@dbussink would you mind reviewing this PR? |
dbussink
reviewed
Jun 27, 2024
dbussink
reviewed
Jun 27, 2024
dbussink
reviewed
Jun 27, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
dbussink
approved these changes
Jun 27, 2024
frouioui
approved these changes
Jun 27, 2024
| ---------------------------------------------------------------------- | ||
| ---------------------------------------------------------------------- |
There was a problem hiding this comment.
clearly some diff I cannot see.
Comment on lines
-535
to
-554
| case *SubQuery: | ||
| return pushOrderingToOuterOfSubquery(ctx, in, src) | ||
| } | ||
| return in, NoRewrite | ||
| } | ||
|
|
||
| func pushOrderingToOuterOfSubquery(ctx *plancontext.PlanningContext, in *Ordering, sq *SubQuery) (Operator, *ApplyResult) { | ||
| outerTableID := TableID(sq.Outer) | ||
| for idx, order := range in.Order { | ||
| deps := ctx.SemTable.RecursiveDeps(order.Inner.Expr) | ||
| if !deps.IsSolvedBy(outerTableID) { | ||
| return in, NoRewrite | ||
| } | ||
| in.Order[idx].SimplifiedExpr = sq.rewriteColNameToArgument(order.SimplifiedExpr) | ||
| in.Order[idx].Inner.Expr = sq.rewriteColNameToArgument(order.Inner.Expr) | ||
| } | ||
| sq.Outer, in.Source = in, sq.Outer | ||
| return sq, Rewrote("push ordering into outer side of subquery") | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this an unreachable code?
There was a problem hiding this comment.
it was not used in any of the queries we tested. this is handled pretty early in the planning process, when the subqueries are still inside a SubqueryContainer, so removing this code made no difference
GuptaManan100
approved these changes
Jun 27, 2024
harshit-gangal
approved these changes
Jun 27, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, arguments are sent as a map to the vttablet, which then incorporates them into the query string using literals. This method works well for types with robust literal support but poses issues for types that do not, such as dates and times.
This PR addresses the issue by altering the handling of types that cannot be easily represented as literals. For these types, we will now use strings and the CAST function to convert them into the correct type within the query, ensuring the values are correctly interpreted by the database.
Example:
The query that triggered this work was:
This would be split up into two different queries:
If the first query returns a decimal value of 50, the second query becomes:
This converts the value to a bigint, not a decimal, which is unexpected.
Related Issue(s)
Fixes #16261
Checklist