resharding: auto-reverse replication #4249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MigrateServedTypes has been made idempotent: if it fails in the middle, you can safely retry the operation. If the operation has previously succeeded, retrying it will be a no-op (except for master migration). For master migration. A new Frozen field has been added to the tablet control record. This field signifies the point of no return. If a migrate fails before reaching this state, then we undo everything and re-enable the source shards. Once we go past the 'frozen' state, you can only go forward. If there are failures after the frozen state, the migrate can be safely retried until successful. Once successful, a retry will return an error saying that there's no resharding in progress. The resharding end to end test has been updated to demonstrate these behaviors. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
MigrateServedTypes for master automatically does the prep work for reversing replication. If the flag is specified, it reverses the direction thereby allowing you to migrate back to the original masters. If the flag was not originally specified, then it only does the prep work, without actually starting the replication. You can later reissue the Migrate command, which will then start the vreplication. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
CancelResharding works for horizontal and vertical resharding as long as migration hasn't started. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
A convenient command for displaying all resharding related data. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
|
This was a trial PR. Closing this. Individual commits will be submitted as separate PRs. |
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of the idempotence PR. I'm just creating it to see if the tests pass.
I'll recreate it formally after idempotence is submitted.