Fixes for vagrant setup #4782
Merged
Fixes for vagrant setup #4782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
| @@ -14,6 +14,10 @@ printf "\nBuilding Vitess...\n" | |||
| sudo chown "$(whoami)":"$(whoami)" /vagrant | |||
| sudo chown "$(whoami)":"$(whoami)" /vagrant/src | |||
| cd "$VITESS_WORKSPACE" | |||
|
|
|||
| # open-jdk version that we are using in the VM needs this flag, otherwise we will fail to build ZK | |||
| export JAVA_TOOL_OPTIONS="-Dhttps.protocols=TLSv1.2" | |||
There was a problem hiding this comment.
Yeah. This is a limitation of the ubuntu version we are using in the Vagrant setup. We need to do some upgrades. openjdk-8 is not available. I think we should do that as part of a different PR.
|
Sure, I just mentioned to keep track of it
…On Wed, 3 Apr 2019 at 17:29, Rafael Chacon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In vagrant-scripts/vitess/build.sh
<#4782 (comment)>:
> @@ -14,6 +14,10 @@ printf "\nBuilding Vitess...\n"
sudo chown "$(whoami)":"$(whoami)" /vagrant
sudo chown "$(whoami)":"$(whoami)" /vagrant/src
cd "$VITESS_WORKSPACE"
+
+# open-jdk version that we are using in the VM needs this flag, otherwise we will fail to build ZK
+export JAVA_TOOL_OPTIONS="-Dhttps.protocols=TLSv1.2"
Yeah. This is a limitation of the ubuntu version we are using in the
Vagrant setup. We need to do some upgrades. openjdk-8 is not available. I
think we should do that as part of a different PR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4782 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD2dmWy7BiI1OpW955Lk_bjHPzl3Mz4Oks5vdMjegaJpZM4cZNPg>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc