Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build issues for MySQL 8 #4840

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

msolters
Copy link
Contributor

@msolters msolters commented Apr 25, 2019

MySQL/Percona 8 containers were being built with the incorrect Dockerfiles and were not receiving the v8.0 my.cnf files they were expecting.

I also deleted some very important-looking whitespace, so let me know if I need to put that back.

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If you don't mind, can you also fix the docker_base_percona80 target in the Makefile?
oh also, fix the DCO by amending your commit with --signoff

Signed-off-by: Mark Solters <msolters@gmail.com>
Signed-off-by: Mark Solters <msolters@gmail.com>
@deepthi deepthi merged commit fac8498 into vitessio:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants