Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jemalloc and tcmalloc to the image build. #5444

Merged
merged 1 commit into from Nov 25, 2019

Conversation

aquarapid
Copy link
Contributor

Not used by default. To use:

  • Set LD_PRELOAD=/usr/lib/libtcmalloc_minimal.so.4
  • or LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libjemalloc.so.1
    in your container startup environment.

Signed-off-by: Jacques Grove aquarapid@gmail.com

Not used by default.  To use:
  * Set LD_PRELOAD=/usr/lib/libtcmalloc_minimal.so.4
  * or  LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libjemalloc.so.1
in your container startup environment.

Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Copy link
Contributor

@saifalharthi saifalharthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what the docker image size is before and after this change?

@aquarapid
Copy link
Contributor Author

After the PR change, the image is about 600 KB larger (843304560 bytes now)

@indera-shsp
Copy link
Contributor

Silly question: it is possible to use only one or the other allocator right?

Good to know

@aquarapid
Copy link
Contributor Author

Correct; use only one. If it wasn't clear from some of the linked issues; tcmalloc was more effective for most users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants