Disable plan cache for all inserts for vtgate and vttablet. #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Few WIP items:
|
|
@systay can you review this approach, or suggest an alternative? |
These blow out memory during bulk imports, and are not useful anyway. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
jacques_nix_insertplancache
branch
from
4a47002
to
ceb623b
Compare
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
force-pushed
the
jacques_nix_insertplancache
branch
from
fd2bc0a
to
386c726
Compare
|
Can we close this? The new caching should work well even for bulk inserts. |
|
Since the plan cache is now memory limited; we don't need this anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These blow out memory during bulk imports, and are not useful anyway.
Signed-off-by: Jacques Grove aquarapid@gmail.com