Clarify default vttablet name #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
force-pushed
the
jacques_doc1
branch
from
c5b6179
to
99e1246
Compare
systay
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Add support for vectors in vreplication workflows. unit and e2e tests. Update cnf file to add loose_with_ps_vectors Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Self review fixes. Add e2e TestVector to CI Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Simplify unit test CI workflow to debug failure Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Skip test on errors on setting with_ps_vectors Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Revert debug mods to unit_race.yml Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Unit test race is again failing with no logs. So modify CI workflow temporarily to get full detail to debug random failures apparently unrelated to this PR Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Setup templating for vectors vreplication build Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Add vcopier unit test. Insert additional rows in e2e test after copy phase to test replication phase Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Switch shard for vector test to correct one Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Use vectors build for unit tests Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Refactor tests: move vector unit tests to separate files Signed-off-by: Rohit Nayak <rohit@planetscale.com> * recognize ERVectorDimensionsMismatch = ErrorCode(4501) as unrecoverable Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Unit race still failing without details:-(. Commenting out the summary code which seems to be redacting the details Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Make tests non-skippable Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Move unit race to vector image Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Add AWS creds to unit race because we need it for S3 access Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Mute tool outputs Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Recreate mysql80 unit test Signed-off-by: Rohit Nayak <rohit@planetscale.com> --------- Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.