Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples pulling in default-fast.cnf #5517

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

gedgar
Copy link
Contributor

@gedgar gedgar commented Dec 5, 2019

Fixes #5516

Signed-off-by: Gary Edgar gary@planetscale.com

Signed-off-by: Gary Edgar <gary@planetscale.com>
Signed-off-by: Gary Edgar <gary@planetscale.com>
@gedgar gedgar requested a review from sougou as a code owner December 5, 2019 23:38
@morgo morgo self-requested a review December 5, 2019 23:40
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi
Copy link
Member

deepthi commented Dec 6, 2019

unit_race shows as failing but if I click through, eveything shows ok, no FAIL. @morgo any idea what's going on with that?

@morgo
Copy link
Contributor

morgo commented Dec 6, 2019

unit_race shows as failing but if I click through, eveything shows ok, no FAIL. @morgo any idea what's going on with that?

There was a failure on a flaky test. I've restarted it:

--- FAIL: TestPlayerCopyTableContinuation (3.93s)
##[error]    vcopier_test.go:517: query:
        "update _vt.vreplication set pos='MySQL56/60e7719c-17bd-11ea-8e08-000d3a03f9ad:1-160', time_updated=1575591285, transaction_timestamp=1575591283, message='' where id=13", does not match query 0:
        "/update _vt.vreplication set state='Running'"
E1206 00:14:47.262510   17055 controller.go:149] stream 17: filter rules are not supported for SBR replication: [match:"dst1" filter:"select * from src1" ], retrying after 5s
E1206 00:14:49.033482   17055 controller.go:149] stream 28: Duplicate column name 'val2' (errno 1060) (sqlstate 42S21) during query: alter table t1 add column val2 varchar(128), retrying after 5s
E1206 00:14:56.236131   17055 controller.go:149] stream 38: vstream ended, retrying after 1ms
E1206 00:14:56.566821   17055 vstreamer.go:648] stream error @ 60e7719c-17bd-11ea-8e08-000d3a03f9ad:1-590: unknown table t1 in schema
FAIL
FAIL	vitess.io/vitess/go/vt/vttablet/tabletmanager/vreplication	35.288s

@morgo morgo merged commit 761c44f into vitessio:master Dec 6, 2019
@morgo morgo deleted the gedgar-fix-cnfs branch December 6, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some examples inadvertently pulling in default-fast.cnf
3 participants