vrepl: fix materializer bug #5715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyrange was getting quoted twice. @rohit-nayak-ps and I discovered this while running some manual tests. This can be best tested with end to end tests, which are coming soon. This is why the unit tests are not affected by this change. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
|
@rohit-nayak-ps you may also review this, since you found the bug :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyrange was getting quoted twice. @rohit-nayak-ps and I
discovered this while running some manual tests. This can
be best tested with end to end tests, which are coming soon.
This is why the unit tests are not affected by this change.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com