Add -db_connect_timeout_ms for timing out mysqld conns.
#5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to fix the formating. |
While testing vttablet-mysqld over TCP, we noticed mysql.Connect sometimes blocks forever if the backend mysqld hit max conns. This patch adds a timeout to this codepath. It defaults to 0 (no timeout) for back compatibility. Signed-off-by: Adam Saponara <as@php.net>
adsr
force-pushed
the
db-conn-timeout
branch
from
f5ebb9d
to
e8b87f9
Compare
|
Woops, missed gofmt on one file. Fixed. |
sougou
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Refreshed version of #5307)
While testing vttablet-mysqld over TCP, we noticed mysql.Connect
sometimes blocks forever if the backend mysqld hit max conns. This
patch adds a timeout to this codepath. It defaults to 0 (no timeout)
for back compatibility.
Signed-off-by: Adam Saponara as@php.net