Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging testcase flakyness remove #6038

Merged
merged 4 commits into from
Apr 13, 2020

Conversation

princeparmar
Copy link
Contributor

@princeparmar princeparmar commented Apr 9, 2020

same result fetched in messaging stream. it was creating flakyness.

changed stream reader and passing only new result. discarding repeating results.

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@deepthi
Copy link
Member

deepthi commented Apr 9, 2020

messaging test is still failing (shard 12):

== RUN   TestMessage
--- FAIL: TestMessage (4.23s)
##[error]    message_test.go:111: epoch: 5, must be 0 or 1
##[error]    message_test.go:130: epoch: 5, must be 1 or 2
=== RUN   TestThreeColMessage
--- PASS: TestThreeColMessage (0.22s)
FAIL
FAIL	vitess.io/vitess/go/test/endtoend/messaging	91.986s
FAIL

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants