vttablet: fix panic in NewDBConnNoPool #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vitessio#6084. The last exporter change introduced a regression due to NewDBConnNoPool creating a tabletenv.Stats with a named exporter, which conflicts with the variables created by the unnamed exporter. This change reuses the stats created for the tabletserver instead. I've tested that the old code panics, and that it doesn't panic after the fix. But I removed the test because it can create other problems if someone created unnamed stats elsewhere. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
harshit-gangal
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6084.
The last exporter change introduced a regression due to NewDBConnNoPool
creating a tabletenv.Stats with a named exporter, which conflicts with
the variables created by the unnamed exporter. This change reuses
the stats created for the tabletserver instead.
I've tested that the old code panics, and that it doesn't panic after
the fix. But I removed the test because it can create other problems
if someone created unnamed stats elsewhere.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com