Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure tests for discoverygateway #6536

Merged
merged 1 commit into from
Aug 5, 2020
Merged

ensure tests for discoverygateway #6536

merged 1 commit into from
Aug 5, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Aug 5, 2020

We have cellAlias and buffer tests for tabletgateway under go/test/endtoend/tabletgateway, so the tests under go/test/endtoend/vtgate can continue to use discoverygateway.
Also fixed TestAddAliasWhileVtgateUp which was failing with tabletgateway.

Signed-off-by: deepthi deepthi@planetscale.com

@deepthi
ensure tests for discoverygateway
1b8f619 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner August 5, 2020 04:20
@sougou sougou merged commit ee8101c into vitessio:master Aug 5, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
@deepthi deepthi deleted the ds-vtgate-tests branch September 9, 2020 23:48
@askdba askdba added this to the v8.0 milestone Oct 5, 2020
@setassociative setassociative mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthi @sougou @askdba