Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Planning and Parsing Support for Create Index of MySQL 5.7 #7024

Merged
merged 14 commits into from
Nov 18, 2020
Merged

Adds Planning and Parsing Support for Create Index of MySQL 5.7 #7024

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0f36c12
Added tests
GuptaManan100 Nov 11, 2020
0567df0
Parsing for create index statements complete
GuptaManan100 Nov 12, 2020
cc05e31
Merged Master
GuptaManan100 Nov 12, 2020
008b88b
Add OnlineHints to Parsing and convert fields to strings
GuptaManan100 Nov 13, 2020
1eedd46
Converted DDL into DDLStatements in builder
GuptaManan100 Nov 13, 2020
bfa23dd
Use Ast incase the query is fully parsed
GuptaManan100 Nov 13, 2020
e55cb63
PlanBuilder at tabletserver changed to use DDLStatement
GuptaManan100 Nov 13, 2020
2dc045b
Merged Master
GuptaManan100 Nov 16, 2020
fcb20fb
TabletServer now uses the AST generated query in case it is fully parsed
GuptaManan100 Nov 16, 2020
7fc96cb
Routing works correctly for create index queries
GuptaManan100 Nov 16, 2020
832c6e5
Added unit tests for QueryExecutor
GuptaManan100 Nov 16, 2020
210aa1a
Added Test for a table not in vschema in unsharded keyspace
GuptaManan100 Nov 18, 2020
e663cee
Merged Master
GuptaManan100 Nov 18, 2020
fd8335e
Fixed test
GuptaManan100 Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions go/vt/vtgate/planbuilder/testdata/ddl_cases.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,21 @@
"SingleShardOnly": false
}
}

# DDL with qualifier
"create index a on main.unknown(id)"
{
"QueryType": "DDL",
"Original": "create index a on main.unknown(id)",
"Instructions": {
"OperatorType": "Send",
"Keyspace": {
"Name": "user",
"Sharded": true
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be main keyspace?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it is fixed in next commit.

"TargetDestination": "AllShards()",
"IsDML": false,
"Query": "create index a on unknown (id)",
"SingleShardOnly": false
}
}