Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Planning and Parsing Support for Truncate, Rename, Drop Index and Flush #7242

Merged
merged 16 commits into from
Jan 11, 2021
Merged

Adds Planning and Parsing Support for Truncate, Rename, Drop Index and Flush #7242

merged 16 commits into from
Jan 11, 2021

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Jan 4, 2021 •
edited

Adds Planning and Parsing Support for Truncate, Drop Index, Rename and Flush. Also, create Index is now converted to an alter table statement during parsing. DDL struct has now been removed since all the different types now have their own structs.

@GuptaManan100
moved truncate out of ddl struct
7810a4c 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Merge remote-tracking branch 'upstream/master' into rename-truncate-f…
32e796e 
…lush

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
moved rename table out of ddl
42c676d 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
fixed ast tests
88e58bb 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
converted create index to alter table statements
a1d387d 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
added complete parsing for drop index and mapped it to a alter table
c1a2b23 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
converted ddl to flush
422f946 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 changed the title Adds Planning and Parsing Support for Truncate, Rename and Flush Adds Planning and Parsing Support for Truncate, Rename, Drop Index and Flush Jan 5, 2021
@GuptaManan100 GuptaManan100 marked this pull request as ready for review January 5, 2021 08:25
harshit-gangal
harshit-gangal reviewed Jan 5, 2021
View reviewed changes
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
@GuptaManan100
refactor rename table struct
f64a4e8 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@shlomi-noach
Copy link
Contributor

@GuptaManan100 please make sure to merge upstream/master, since I've recently added changes to ast.go which I don't see here; specifically, added a GetIfExists() function to DDLStatement interface.

@GuptaManan100
complete parsing for flush
50792e9 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as draft January 6, 2021 11:41
@GuptaManan100
Merge remote-tracking branch 'upstream/master' into rename-truncate-f…
adc7696 
…lush

Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
Copy link
Member Author

Ah yes, this was also the reason why my PR was failing all the tests even though they were passing locally. Thankyou @shlomi-noach!

@GuptaManan100
planning support for flush
0b68ad2 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
added endtoend test for flush
fbdd72b 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review January 6, 2021 13:32
harshit-gangal
harshit-gangal reviewed Jan 6, 2021
View reviewed changes
go/vt/vtgate/planbuilder/builder.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/builder.go Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/ddl_cases.txt Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/testdata/ddl_cases.txt Outdated Show resolved Hide resolved
@GuptaManan100
moved flush tests to their files
4e779e6 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
added routing rules test for flush
a3a3a60 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
does not allow unknown tables to be passed in flush statements
e51e3d5 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
altered concatenate primitive to accept more than 2 primitives
ec0aa0c 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
systay
systay approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the comment about formatTwoOptionsNicely, LGTM

@shlomi-noach
Copy link
Contributor

DDL struct has now been removed

WHOA!

@systay systay merged commit a489616 into vitessio:master Jan 11, 2021
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
@eseokoh eseokoh mentioned this pull request May 31, 2021
Closed
@ajm188 ajm188 mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
Component: Query Serving
Projects
No open projects
Complete Parsing DDL Support for mysq...
Done
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GuptaManan100 @shlomi-noach @systay @harshit-gangal @askdba