Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

slack vitess v10.pre #228

Merged
merged 2,028 commits into from Jul 21, 2021
Merged

slack vitess v10.pre #228

merged 2,028 commits into from Jul 21, 2021

Conversation

ajm188
Copy link

@ajm188 ajm188 commented Jul 10, 2021

Description

Some notes about these commits:

  • due to some git detail that I havent' bothered to figure out, there are merge commits that were technically already in tinyspeck/master in some form, but due to (I think?) the backporting from vitessio/main to vitessio/v10.0.2 they still show up in the git log --reverse --merges master...HEAD. I'm calling out any of the PRs that I think fit that description.
  • There are a few commits I authored on the end of this branch in order to get tests passing; I've left them as is for now, but a few of them are fixups/eventual-reverts, so I plan to clean them up before merging.
  • I will construct a separate branch for the vtctld build based on this one.

vttablet

vtgate

vtctld

vtadmin

topo

vreplication

performance

credentials

sqlparser

orchestrator

build

ci

misc

GuptaManan100 and others added 30 commits March 23, 2021 12:31
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
split ast_helper into individual gen files
โ€ฆerent shards in a stream

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Adds support for ordering on character fields for sharded keyspace queries
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Hormoz K <hkheradm@gmail.com>
Signed-off-by: Hormoz K <hkheradm@gmail.com>
Signed-off-by: Hormoz K <hkheradm@gmail.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Hormoz K <hkheradm@gmail.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Make vttestserver compatible with persistent data directories
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
systay and others added 11 commits July 8, 2021 14:01
Signed-off-by: Andres Taylor <andres@planetscale.com>
โ€ฆess-v10.pre

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Version 10.0.2

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Here's why:

```
โฏ go mod why github.com/moby/term
vitess.io/vitess/go/vt/vttablet/onlineddl
github.com/skeema/tengo
github.com/fsouza/go-dockerclient
github.com/docker/docker/pkg/jsonmessage
github.com/moby/term
```

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
git seemed to not apply this change after the formatting functions got
moved from `ast.go` to `ast_format.go`

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Done via `git checkout v10.0.2 -- "${test_file}"`

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 marked this pull request as ready for review July 19, 2021 11:55
@ajm188 ajm188 requested a review from doeg as a code owner July 19, 2021 11:55
@ajm188
Copy link
Author

ajm188 commented Jul 19, 2021

Looks like we're missing these changes:

DDL bypass plan

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Copy link

@guidoiaquinti guidoiaquinti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we really need to improve this process.

@ajm188 ajm188 merged commit 9cdca7a into master Jul 21, 2021
@ajm188 ajm188 deleted the am_slack-vitess-v10.pre branch July 21, 2021 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet