added default databases when calling 'show databases' #7256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akilan1999
force-pushed
the
show_information_schema
branch
from
1f2f447
to
1fd5870
Compare
systay
approved these changes
Jan 7, 2021
harshit-gangal
approved these changes
Jan 7, 2021
| for _, query := range []string{"show databases", "show DATABASES", "show schemas", "show SCHEMAS"} { | ||
| qr, err := executor.Execute(ctx, "TestExecute", session, query, nil) | ||
| require.NoError(t, err) | ||
| // Showing default tables (5+4[default]) |
Signed-off-by: akilan <Akilanselva@hotmail.com>
Akilan1999
force-pushed
the
show_information_schema
branch
from
1fd5870
to
ebbf34e
Compare
|
nice! thanks @Akilan1999 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added default databases when calling 'show databases'.
Previously show databases and keyspaces acted as the same.
Related Issue(s)
#7158
Checklist
Impacted Areas in Vitess
Components that this PR will affect: