VReplication: Miscellaneous improvements #7275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nayak-ps
force-pushed
the
rn-vrepl-misc
branch
2 times, most recently
from
6db2abd
to
e891283
Compare
rohit-nayak-ps
requested review from
ajm188,
deepthi,
doeg,
harshit-gangal,
sougou and
systay
as code owners
rohit-nayak-ps
changed the title
sougou
approved these changes
Jan 19, 2021
|
Feel free to merge after conflicts are resolved. |
rohit-nayak-ps
force-pushed
the
rn-vrepl-misc
branch
from
dcaa521
to
4315e84
Compare
…t types Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…t types Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-vrepl-misc
branch
from
4315e84
to
70ec3c5
Compare
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
aquarapid
added a commit
to planetscale/vitess
that referenced
this pull request
Aug 5, 2021
this year in PR vitessio#7275 to change the vreplication_tablet_type defaults. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change MoveTables/Reshard Start to Create
In V2 the Start sub-command both creates the workflow and starts the streams. This is confusing since it is the same term used to set the state of a workflow to Running in the Workflow command.
Add both Master and Replica as default tablet picker choices
We had just Replica as a default for tablet types that the tablet picker would use to choose a source tablet for vreplication streams. However for initial migration into Vitess users just have a single vttablet proxying their existing MySQL server and thus have just a Master tablet type. This would result in the vreplication streams getting stuck. With this PR this default is both replica and master.
Don't require switching rdonly tablets if none exist
Many setups do not have rdonly tablets. (Also rdonly is going to be deprecated soon). Currently we only consider a workflow as fully switched forward if all tablet types are switched. Thus users are forced to run a noop command to switch rdonly tablets. This PR automatically marks rdonly tablets as switched if user switches replicas and, at the time of the forward or reverse switch, there are no rdonly tablets in the associated (source for forward, target for reverse) keyspace.
Don't allow forward switching if workflow is in copy state
This PR adds a sanity check that a workflow is replicating and is no longer in the Copying state. The user is supposed to use VDiff and Workflow Show tools to validate that the workflow has completed copying as an operational best practice, but since it can be overlooked this sanity check has been added. Note that we are not yet checking for an acceptable lag: in practice once copy is completed lags should be small anyway and an acceptable lag is anyway subjective. We might add this later if we find it is useful and can be well specified.
This should be backported to 9.0 RC since we have changed the Start subcommand to Create and this release introduces v2.
Checklist
Impacted Areas in Vitess
Components that this PR will affect: