Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vreplication V2 Workflows: rename Abort to Cancel #7276

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

Signed-off-by: Rohit Nayak rohit@planetscale.com

Description

For neutral naming, all references to workflow.Abort renamed to workflow.Cancel.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review January 9, 2021 11:13
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m!

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 625aea9 into vitessio:master Jan 12, 2021
@deepthi deepthi deleted the rn-abort-is-now-cancel branch January 12, 2021 18:02
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
deepthi added a commit that referenced this pull request Jan 21, 2021
Backport #7276: Vreplication V2 Workflows: rename Abort to Cancel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants