Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some unit test cases for CREATE TABLE parser #7279

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Added some unit test cases for CREATE TABLE parser #7279

merged 2 commits into from
Jan 11, 2021

Conversation

shlomi-noach
Copy link
Contributor

Description

Merely adding a few test cases for parse_test.go to validate some CREATE TABLE variations.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

@shlomi-noach
Added some unit test cases for CREATE TABLE parser
534b54d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
a couple more tests
450bef1 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@systay systay merged commit b771bdf into vitessio:master Jan 11, 2021
@systay systay deleted the create-table-parse-test branch January 11, 2021 13:57
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
@ajm188 ajm188 mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlomi-noach @systay @askdba