Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed resolver usage from StreamExecute #7281

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jan 11, 2021

Description

Removed the resolver logic when shard targeting. This enabled planing to be done for all queries. Planner knows how to work with shard targeting.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review January 11, 2021 10:23
@systay systay merged commit bb3c7dd into vitessio:master Jan 11, 2021
@systay systay deleted the olap-remove-resolver branch January 11, 2021 14:01
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issuing a USE statement while in OLAP / streaming mode with shard targeting causes non-fatal vttablet panic
3 participants