Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CALL procedures #7287

Merged
merged 31 commits into from Jan 27, 2021
Merged

Support for CALL procedures #7287

merged 31 commits into from Jan 27, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Jan 12, 2021 •
edited by harshit-gangal

This PR makes it possible to run CALL queries against vtgate.

For now, this is only allowed if either specifically target specific shards, or if you are running on an unsharded keyspace.

  • Parsing CALL
  • vtgate/vttablet planning of CALL
  • Table should read multi results from MySQL server
    - [x] Send multi results from tablet over grpc
    - [ ] Send multi results from vtgate to client over mysql protocol
  • Write docs CALL proc is now supported website#672
  • Check the state of the connection to MySQL from the tablet after running a sproc, so no transactions are left open
    - [ ] Make sure CALL works in both streaming and non-streaming modes It will be handled in separate PR

@systay systay marked this pull request as ready for review January 15, 2021 07:32
harshit-gangal
harshit-gangal reviewed Jan 15, 2021
View reviewed changes
go/mysql/endtoend/client_test.go Outdated Show resolved Hide resolved
go/test/endtoend/cluster/vtctlclient_process.go Outdated Show resolved Hide resolved
go/test/endtoend/vtgate/unsharded/main_test.go Outdated Show resolved Hide resolved
go/vt/sqlparser/sql.y Show resolved Hide resolved
go/vt/vtgate/planbuilder/call_proc.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletserver/query_executor.go Outdated Show resolved Hide resolved
@systay systay mentioned this pull request Jan 19, 2021
Merged
systay and others added 14 commits January 20, 2021 14:35
@systay @harshit-gangal
Added parsing and AST for CALL procedure
4416b48 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
added vtgate planning for CALL
82d0208 
Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay @harshit-gangal
plan CALL queries correctly
b7fc167 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
added executor tests for CALL proc
49ed536 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
rebuild the parser with the new sql.y
5180294 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
updated test assertions
46a0bb9 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
add more tests around procedures returning muliple results
345dec1 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @harshit-gangal
address peer review comments
9aa29d7 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
fetchnext on connection to retrieve next resultset on mysql connection
f5a74b1 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added vttablet call procedure query executor
e5b5003 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix vtgate e2e test
5b824bb 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added e2e test and fix conn unlock on fetch next
1c35f7b 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added e2e test from vttablet
228968e 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added sleep to vtgate e2e test
e6b8763 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
no change on mysql package. Removed the added tests
e32cbfa 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
block call procedure call inside a transaction
13f810a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added e2e test in vttablet for tx call proc
2925662 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added support for call proc to work in reserved connection outside of…
502a6a1 
… transaction

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
parseEOFPacket to return status flags
f89bae8 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
result to return status flags and fixed all the tests
57d35e9 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
result to return status flags and fixed all the tests
c8dbe44 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
check transaction and error out if on non-tx pool transaction is left…
295572e 
… open

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
transaction state change not allowed inside the active transaction us…
8cbe671 
…ing stored procedure

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
return the error code as CANCELLED for tx change not allowed in sproc
7b65d60 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix test to add statusFlags
fbe4e0d 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
systay commented Jan 26, 2021
View reviewed changes
go/sqltypes/result.go Outdated Show resolved Hide resolved
@systay
Merge remote-tracking branch 'upstream/master' into call-proc
d20e588 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
fix call_cases.txt and run the planning tests
a7ac0fd 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
use constants for easier reading
0d5c351 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
add failing endtoend tests
9b2c6ed 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
make CALL work with parameters
7eb3d35 
* make sure to rewrite queries when vtgate plans
* make sure to use the generated query on the tablet
* check for INOUT/OUT params errors and rewrite the error message

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
make tests green
9438171 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal harshit-gangal mentioned this pull request Jan 27, 2021
Open
9 tasks
@harshit-gangal harshit-gangal merged commit 68286d9 into vitessio:master Jan 27, 2021
@harshit-gangal harshit-gangal deleted the call-proc branch January 27, 2021 12:30
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@ajm188 ajm188 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@sougou sougou Awaiting requested review from sougou

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@systay @harshit-gangal @askdba