added vitess_version as variable #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akilan <me@akilan.io>
Akilan1999
added
Type: Enhancement
systay
approved these changes
Jan 14, 2021
indera-shsp
reviewed
Apr 30, 2021
| } | ||
|
|
||
| func TestRewrites(in *testing.T) { | ||
| tests := []myTestCase{{ | ||
| in: "SELECT 42", | ||
| expected: "SELECT 42", | ||
| // no bindvar needs | ||
| }, { | ||
| in: "SELECT @@vitess_version", |
There was a problem hiding this comment.
Is this query supposed to work?
There was a problem hiding this comment.
this works
SELECT @@version_comment;
+----------------------------------------------------------------------------------------------------------------------------------------------+
| @@version_comment |
+----------------------------------------------------------------------------------------------------------------------------------------------+
| Version: 11.0.0-SNAPSHOT (Git revision branch '') built on Fri Apr 30 16:22:55 UTC 2021 by root@buildkitsandbox using go1.15.11 linux/amd64 |
+----------------------------------------------------------------------------------------------------------------------------------------------+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akilan me@akilan.io
Description
added vitess_version as variable
Related Issue(s)
fixes #3112
Checklist