Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose vtctld gRPC port in local Docker example + update VTAdmin README #7306

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Jan 15, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

A couple tiny changes to get ✨ #7266 ✨ working with local Docker! (I promise promise to add a tidy make target in lieu of those four five README steps... soon... 🙈)

Screen Shot 2021-01-15 at 4 00 44 PM

Related Issue(s)

Checklist

  • Should this PR be backported? N/A
  • Tests were added or are not required N/A
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

```

1. Finally! Start up vtadmin-web on [http://localhost:3000](http://localhost:3000), pointed at the vtadmin-api server you started in the last step.

```bash
cd web/vtadmin
npm install
REACT_APP_VTADMIN_API_ADDRESS="http://127.0.0.1:15999" npm start
REACT_APP_VTADMIN_API_ADDRESS="http://127.0.0.1:14200" npm start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chef-kiss:

@rohit-nayak-ps rohit-nayak-ps merged commit 0fa0fc7 into vitessio:master Jan 15, 2021
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
@doeg doeg added this to In progress in VTAdmin via automation Mar 16, 2021
@doeg doeg moved this from In progress to Done in VTAdmin Mar 16, 2021
@doeg doeg deleted the sarabee-vtadmin-docker-vtctlds-and-you branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants