Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add React Router + a skeleton /debug page to VTAdmin #7310

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Jan 16, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

Adds react router + a /debug page. Another tiny PR pulled out of a bigger branch.

For a little context, I plan to co-opt the debug page as an informal style guide as I add all of the components in the Figma spec. (In the past, I've used Storybook for this, but I think that's way overkill for what we need for the near future.)

No one asked, but my $0.02 anyway (haha). I personally prefer ui-router over React Router. (I think it's more straightforward.) That said, the ui-router documentation is very painful to navigate. React Router has better documentation and I think it's fair to that it's still the industry (or at least React!) standard, so I think it's a better + more approachable choice for an open source project.

Looks great so far, right? :D (Just kidding.)

Screen Shot 2021-01-16 at 1 40 55 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required N/A
  • Documentation was added or is not required N/A

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rohit-nayak-ps rohit-nayak-ps merged commit a0aa954 into vitessio:master Jan 18, 2021
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
@doeg doeg changed the title Add React Router + a skeleton /debug page to VTAdmin [vtadmin-web] Add React Router + a skeleton /debug page to VTAdmin Mar 16, 2021
@doeg doeg added the Component: VTAdmin VTadmin interface label Mar 16, 2021
@doeg doeg added this to In progress in VTAdmin via automation Mar 16, 2021
@doeg doeg moved this from In progress to Done in VTAdmin Mar 16, 2021
@doeg doeg deleted the sarabee-vtadmin-debug-page branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants