Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-web] Add NavRail component #7316

Merged
merged 4 commits into from
Jan 19, 2021
Merged

[vtadmin-web] Add NavRail component #7316

merged 4 commits into from
Jan 19, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Jan 18, 2021 •
edited

Description

✨ Staged at http://vtadmin.puppy.software ✨

What this does:

  • Adds the NavRail component. The sidebar, that is. :)
  • Simplifies CSS variables for light/dark themes.

Screen Shot 2021-01-18 at 3 05 43 PM

Screen Shot 2021-01-18 at 3 06 20 PM

What this does not do:

  • This isn't pixel perfect quite yet. I expect more CSS tweaks to come. :)
  • This makes no attempt at a really nice responsive layout. It is, however, a serviceable responsive layout since it technically "works" for any viewport... as long as you don't mind scrolling, hehe.

Screen Shot 2021-01-18 at 3 14 14 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required N/A (pretty much all layout changes)
  • Documentation was added or is not required N/A

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

@doeg
Add NavRail component
9366bdc 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Dark mode 😎
8c641aa 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Nits 🐐
4c13f43 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Simplify layout on Error404 component
746f45a 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
rohit-nayak-ps
rohit-nayak-ps approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 9a3d932 into vitessio:master Jan 19, 2021
@askdba askdba added this to the v9.0 milestone Jan 19, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Jan 25, 2021
@doeg doeg changed the title Add NavRail component [vtadmin-web] Add NavRail component Mar 16, 2021
@doeg doeg added this to In progress in VTAdmin via automation Mar 16, 2021
@doeg doeg moved this from In progress to Done in VTAdmin Mar 16, 2021
@eseokoh eseokoh mentioned this pull request May 31, 2021
Closed
@ajm188 ajm188 mentioned this pull request Jul 12, 2021
Merged
@doeg doeg deleted the sarabee-vtadmin-navrail-tycoon branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface
Projects
VTAdmin
Done
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doeg @rohit-nayak-ps @askdba