Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtctld] Add GetSrvVSchema command #7334

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jan 21, 2021

Description

This implements GetSrvVSchema in the vtctld service. Pretty straightforward.

Sample output from local example:

❯ vtctldclient --server "localhost:15999" GetSrvVSchema zone1
{
  "keyspaces": {
    "commerce": {
      "sharded": false,
      "vindexes": {
      },
      "tables": {
        "corder": {
          "type": "",
          "column_vindexes": [
          ],
          "auto_increment": null,
          "columns": [
          ],
          "pinned": "",
          "column_list_authoritative": false
        },
        "customer": {
          "type": "",
          "column_vindexes": [
          ],
          "auto_increment": null,
          "columns": [
          ],
          "pinned": "",
          "column_list_authoritative": false
        },
        "product": {
          "type": "",
          "column_vindexes": [
          ],
          "auto_increment": null,
          "columns": [
          ],
          "pinned": "",
          "column_list_authoritative": false
        }
      },
      "require_explicit_routing": false
    }
  },
  "routing_rules": {
    "rules": [
    ]
  }
}

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from doeg January 21, 2021 01:16
@ajm188 ajm188 requested a review from sougou as a code owner January 21, 2021 01:16
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Copy link
Contributor

@doeg doeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A task so straightforward I could have done it!!!!!

image

(Thank you! 💛 )

@@ -258,6 +259,88 @@ func TestGetTablet(t *testing.T) {
assert.Error(t, err)
}

func TestGetSrvVSchema(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So amazing to have tests 😭 and the tests are good

@rohit-nayak-ps rohit-nayak-ps merged commit 4264302 into vitessio:master Jan 21, 2021
@askdba askdba added this to the v9.0 milestone Jan 25, 2021
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Feb 11, 2021
setassociative pushed a commit to tinyspeck/vitess that referenced this pull request Mar 11, 2021
ajm188 pushed a commit to tinyspeck/vitess that referenced this pull request Apr 6, 2021
[vtctld] Add GetSrvVSchema command

Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 added this to In progress in Vtctld Service via automation May 23, 2021
@ajm188 ajm188 moved this from In progress to Done in Vtctld Service May 23, 2021
@ajm188 ajm188 deleted the am_vtctld_getsrvvschema branch May 29, 2021 10:25
@doeg doeg mentioned this pull request May 31, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants