-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctld] Add GetSrvVSchema command #7334
Merged
rohit-nayak-ps
merged 3 commits into
vitessio:master
from
tinyspeck:am_vtctld_getsrvvschema
Jan 21, 2021
Merged
[vtctld] Add GetSrvVSchema command #7334
rohit-nayak-ps
merged 3 commits into
vitessio:master
from
tinyspeck:am_vtctld_getsrvvschema
Jan 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_vtctld_getsrvvschema
branch
from
January 21, 2021 01:26
00c08d0
to
4f9ae68
Compare
doeg
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -258,6 +259,88 @@ func TestGetTablet(t *testing.T) { | |||
assert.Error(t, err) | |||
} | |||
|
|||
func TestGetSrvVSchema(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So amazing to have tests 😭 and the tests are good
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Feb 11, 2021
[vtctld] Add GetSrvVSchema command
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 11, 2021
[vtctld] Add GetSrvVSchema command
ajm188
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 6, 2021
[vtctld] Add GetSrvVSchema command Signed-off-by: Andrew Mason <amason@slack-corp.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements
GetSrvVSchema
in the vtctld service. Pretty straightforward.Sample output from local example:
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: