Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add icons + focus state to NavRail #7365

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Jan 25, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

As it says on the tin!

Before:

Screen Shot 2021-01-24 at 7 28 11 PM

After:

Screen Shot 2021-01-24 at 8 42 22 PM

Screen Shot 2021-01-24 at 8 42 27 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported?
  • Tests were added or are not required N/A
  • Documentation was added or is not required N/A

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

@doeg
Copy link
Contributor Author

doeg commented Jan 25, 2021

Whoops, one sec -- of course I got one of the icons wrong. 😑

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Copy link
Contributor Author

doeg commented Jan 25, 2021

Ok fixed! 😰 Sorry about that. This is ready for real now!

@doeg doeg force-pushed the sarabee-vtadmin-navrail-icons branch from 89fd9d6 to 1790bfb Compare January 25, 2021 01:50
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit 627f092 into vitessio:master Jan 25, 2021
@doeg doeg changed the title Add icons + focus state to NavRail [vtadmin-web] Add icons + focus state to NavRail Mar 16, 2021
@doeg doeg added this to In progress in VTAdmin via automation Mar 16, 2021
@doeg doeg added the Component: VTAdmin VTadmin interface label Mar 16, 2021
@doeg doeg moved this from In progress to Done in VTAdmin Mar 16, 2021
@doeg doeg deleted the sarabee-vtadmin-navrail-icons branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants