gen4: fail unsupported queries #7409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
moved this PR to draft, as there is some more work to do done on this. |
Signed-off-by: Andres Taylor <andres@planetscale.com>
|
Cleaned up, squashed and rebased. I think this can go in now |
harshit-gangal
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Then Gen4 planner is growing, but there is still a lot of query types that are not supported. This PR makes sure to fail the unsupported cases instead of producing bad plans.
Related Issue(s)
Gen4 tracking #7280
Impacted Areas in Vitess
Components that this PR will affect:
No docs are needed.