Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ErrorGroup to package concurrency, use in waitOnNMinusOneTablets #7429

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Add ErrorGroup to package concurrency, use in waitOnNMinusOneTablets #7429

merged 1 commit into from
Feb 2, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Feb 2, 2021

Description

This is part of a larger effort to migrate PlannedReparentShard and EmergencyReparentShard for #7428, and I'm trying to lead with some refactors to make the actual final change less scary (I'm working on a few more extractions that will have tests attached to them, which should hopefully give us even more confidence in the final change).

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required No
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@ajm188
Add ErrorGroup to package concurrency, use in waitOnNMinusOneTablets
ec19dba 
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 added this to In progress in Vtctld Service via automation Feb 2, 2021
deepthi
deepthi approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

@deepthi deepthi merged commit 9716598 into vitessio:master Feb 2, 2021
Vtctld Service automation moved this from In progress to Done Feb 2, 2021
@deepthi
Copy link
Member

deepthi commented Feb 2, 2021

cc @PrismaPhonic

@doeg
Copy link
Contributor

doeg commented Feb 2, 2021

I'm late to the merge party but just wanna say this change is :chef-kiss: 🌟

@PrismaPhonic
Copy link
Contributor

Looks great!

@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@ajm188 ajm188 deleted the am_error_group branch March 4, 2021 16:32
setassociative pushed a commit to tinyspeck/vitess that referenced this pull request Mar 8, 2021
@deepthi @setassociative
Merge pull request vitessio#7429 from tinyspeck/am_error_group
d1b4d2c 
Add `ErrorGroup` to package concurrency, use in `waitOnNMinusOneTablets`
@setassociative setassociative mentioned this pull request Mar 8, 2021
Closed
@ajm188 ajm188 added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label May 23, 2021
@ajm188 ajm188 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@doeg doeg Awaiting requested review from doeg

@setassociative setassociative Awaiting requested review from setassociative

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Vtctld Service
  
Done
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ajm188 @deepthi @doeg @PrismaPhonic @askdba