Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Olap error message fix #7448

Merged
merged 2 commits into from Feb 4, 2021
Merged

Olap error message fix #7448

merged 2 commits into from Feb 4, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 4, 2021 •
edited

Description

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@harshit-gangal
error on transaction statement in streaming mode
fc096f1 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added executor stream unit test
4099efd 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review February 4, 2021 19:05
@harshit-gangal harshit-gangal merged commit 2e36581 into vitessio:master Feb 4, 2021
@harshit-gangal harshit-gangal deleted the olap-error-fix branch February 4, 2021 19:16
@deepthi
Copy link
Member

deepthi commented Feb 4, 2021

That was fast! Nice work on the unit tests!

@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@ajm188 ajm188 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Confusing error message when trying to start transaction in OLAP workload mode
4 participants
@harshit-gangal @deepthi @systay @askdba