Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtctld/wrangler] Extract EmergencyReparentShard logic to dedicated struct and add unit tests #7464

Merged
merged 3 commits into from
Feb 9, 2021
Merged

[vtctld/wrangler] Extract EmergencyReparentShard logic to dedicated struct and add unit tests #7464

merged 3 commits into from
Feb 9, 2021

Commits on Feb 8, 2021

  1. Update AddTablet to take options, update callers 

    Enforcing single-MASTER shards is something only certain tests will
want, and in fact adding this behavior to `testutil.AddTablet` without
this option broke several existing tests.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    0a5c1c3 View commit details
    Browse the repository at this point in the history

  2. Make testutil.AddTablet and testutil.AddShards more flexible 

    Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    7acf52c View commit details
    Browse the repository at this point in the history

  3. Extract EmergencyReparentShard logic to dedicated struct and add un… 

    …it tests

This for increasing test coverage on the ERS code as well as to set us
up for code reuse between the new vtctld and legacy vtctl RPCs in a
future PR.

Signed-off-by: Andrew Mason <amason@slack-corp.com>
    @ajm188
    ajm188 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    500b2e6 View commit details
    Browse the repository at this point in the history