[vtctld/wrangler] Extract EmergencyReparentShard logic to dedicated struct and add unit tests
#7464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajm188
commented
Feb 7, 2021
|
|
||
| event.DispatchUpdate(ev, "reparenting all tablets") | ||
|
|
||
| // (@ajm188) - A question while migrating: Is this by design? By my read, |
There was a problem hiding this comment.
@deepthi question for you in particular here. @setassociative this is the issue I was talking to you about the other day.
There was a problem hiding this comment.
It seems like an oversight. Either we care about errors from handleReplica and we should process them or not send them at all. The original design is documented in #6206 but I don't see that it goes into the details of error handling.
ajm188
force-pushed
the
am_emergency_reparenter
branch
from
05e2207
to
ffd870e
Compare
Enforcing single-MASTER shards is something only certain tests will want, and in fact adding this behavior to `testutil.AddTablet` without this option broke several existing tests. Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
…it tests This for increasing test coverage on the ERS code as well as to set us up for code reuse between the new vtctld and legacy vtctl RPCs in a future PR. Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_emergency_reparenter
branch
from
ffd870e
to
500b2e6
Compare
deepthi
approved these changes
Feb 9, 2021
|
Yep, I just filed #7480 to track that. I'll work on a fix after I finish up tests on |
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 8, 2021
[vtctld/wrangler] Extract `EmergencyReparentShard` logic to dedicated struct and add unit tests Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly what it says in the title. I'll follow up with a
PlannedReparenterPR soonish to do the same thing to that set of functionality.This for increasing test coverage on the ERS code as well as to set us
up for code reuse between the new vtctld and legacy vtctl RPCs in a
future PR.
Signed-off-by: Andrew Mason amason@slack-corp.com
Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: