Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Query Serving when Toposerver is Down #7484

Merged
merged 7 commits into from
Feb 17, 2021
Merged

Fix for Query Serving when Toposerver is Down #7484

merged 7 commits into from
Feb 17, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 11, 2021 •
edited

Description

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

harshit-gangal and others added 3 commits February 11, 2021 18:13
@harshit-gangal
added e2e test for query serving even when topo server is down
4477665 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
do not evict cache if unable to connect to topo server
bfceeb3 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay
make sure to keep data even when topo server is deleted
2755dce 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay marked this pull request as ready for review February 15, 2021 07:39
@harshit-gangal
added toposerver down testing for zk, consul and etcd
04353cf 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
added to ci tests
df439ab 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fixed e2e test config for zk and consul
2c28656 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
test in right shard
f5384de 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
deepthi
deepthi reviewed Feb 16, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Just a couple of minor questions/comments.

go/test/endtoend/cluster/cluster_process.go Show resolved Hide resolved
go/test/endtoend/cluster/topo_process.go Show resolved Hide resolved
@harshit-gangal harshit-gangal merged commit 8b6e690 into vitessio:master Feb 17, 2021
@harshit-gangal harshit-gangal deleted the consul-qs-fix branch February 17, 2021 09:12
@askdba askdba added this to the v10.0 milestone Feb 22, 2021
@harshit-gangal harshit-gangal mentioned this pull request May 5, 2021
Merged
@serhatcetinkaya serhatcetinkaya mentioned this pull request May 11, 2021
Closed
@ajm188 ajm188 mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

@systay systay Awaiting requested review from systay

Assignees

@harshit-gangal harshit-gangal

Labels
Component: Cluster management
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Vitess returns error when Consul topology service is unavailable
4 participants
@harshit-gangal @deepthi @askdba @systay