[vtadmin-web] Add replaceQuery + pushQuery to useURLQuery hook #7507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doeg
changed the title
doeg
force-pushed
the
sarabee-vtadmin-url-query-callbacks
branch
from
75100c7
to
93ff80a
Compare
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
doeg
force-pushed
the
sarabee-vtadmin-url-query-callbacks
branch
from
93ff80a
to
5bb242c
Compare
ajm188
approved these changes
Feb 17, 2021
| const history = useHistory(); | ||
| const location = useLocation(); | ||
|
|
||
| // A spicy note: typically, we always want to use the `location` from useLocation() instead of useHistory(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
This returns
pushQueryandreplaceQueryfunctions from theuseURLQueryhook. A bit of refactoring to simplify pushing + replacing URL query parameters with common defaults.Staged at http://vtadmin.puppy.software, although there's not much to see. Going to a URL like http://vtadmin.puppy.software/tablets?page=1234567890 will show
replaceQueryin action.Related Issue(s)
N/A
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: