Change Error Messages In VTGate #7514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
fix-vtgate-errors
branch
from
cb512f5
to
e0e57dd
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…o vterrors state Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…enerate vterrors errors that will be converted later to mysql errors Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
fix-vtgate-errors
branch
from
fe89ca0
to
dfbf58d
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…executor in vtgate Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
requested review from
shlomi-noach,
sougou and
systay
as code owners
…rrors Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
reviewed
Mar 1, 2021
| @@ -162,6 +149,56 @@ func NewSQLErrorFromError(err error) error { | |||
| return serr | |||
| } | |||
|
|
|||
| var stateToMysqlCode = map[vterrors.State]struct { | |||
systay
reviewed
Mar 1, 2021
systay
reviewed
Mar 1, 2021
| @@ -185,6 +188,24 @@ func Code(err error) vtrpcpb.Code { | |||
| return vtrpcpb.Code_UNKNOWN | |||
| } | |||
|
|
|||
| // ErrState returns the error state if it's a vtError. | |||
systay
reviewed
Mar 1, 2021
| } | ||
| for i, field2 := range fields2 { | ||
| field1 := fields1[i] | ||
| if field1.Type != field2.Type { | ||
| return vterrors.Errorf(vtrpcpb.Code_INVALID_ARGUMENT, "column field type does not match for name: (%v, %v) types: (%v, %v)", field1.Name, field2.Name, field1.Type, field2.Type) | ||
| return vterrors.Errorf(vtrpcpb.Code_UNIMPLEMENTED, "merging field of different types is not supported, name: (%v, %v) types: (%v, %v)", field1.Name, field2.Name, field1.Type, field2.Type) |
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
reviewed
Mar 1, 2021
go/vt/vtgate/vcursor_impl.go
Outdated
| if !allowed { | ||
| return vterrors.Errorf(vtrpcpb.Code_PERMISSION_DENIED, "not authorized to perform vschema operations") | ||
|
|
||
| return vterrors.NewErrorf(vtrpcpb.Code_PERMISSION_DENIED, vterrors.AccessDeniedError, "User '%s' to perform vschema operations", user.GetUsername()) |
There was a problem hiding this comment.
this message looks a bit weird to me.
shouldn't it say: User '%s' is not authorized to perform vschema operations
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
fix-vtgate-errors
branch
from
dd7e031
to
08765a7
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
force-pushed
the
fix-vtgate-errors
branch
from
619cb1d
to
2ab202b
Compare
The error is always send back to client. If the target is not nil then it is added to the error message. I will go ahead and merge the PR. If there is any concern we can fix forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harshit Gangal harshit@planetscale.com
Description
Related Issue(s)
#7533
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: