[vtadmin-web] Add a Select component #7524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
selects.mov
A quick first pass at a Select component using Downshift (which is very good indeed). I expect to refine this a fair amount since I'll be adding other components (Multiselect, Combobox, etc.) that will share a lot of styling + behaviour. But this felt like a good stopping point!
I'll also note that the "Clear selection" button is a still little clunky, since it doesn't play very nicely with Downshift's exceedingly-reasonable-yet-somewhat-aggressive tabindex management. It works fine, but is not keyboard accessible.
Not staged, since #7515 is already up .
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: