Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add a Select component #7524

Merged
merged 4 commits into from Feb 23, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Feb 19, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

selects.mov

A quick first pass at a Select component using Downshift (which is very good indeed). I expect to refine this a fair amount since I'll be adding other components (Multiselect, Combobox, etc.) that will share a lot of styling + behaviour. But this felt like a good stopping point!

I'll also note that the "Clear selection" button is a still little clunky, since it doesn't play very nicely with Downshift's exceedingly-reasonable-yet-somewhat-aggressive tabindex management. It works fine, but is not keyboard accessible.

Not staged, since #7515 is already up .

Related Issue(s)

N/A

Checklist

  • Should this PR be backported? N/A
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m!

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg
Copy link
Contributor Author

doeg commented Feb 22, 2021

Sorry to dismiss the approval. I pushed another small change that:

  • Fix an oversight the height of the modal was always 40vh, rather that min-content
  • Adds an emptyPlaceholder prop to the select component invoked when the items array is empty.

Screen Shot 2021-02-21 at 9 22 27 PM

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@deepthi deepthi merged commit d6022cd into vitessio:master Feb 23, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Feb 26, 2021
@askdba askdba added this to the v10.0 milestone Feb 26, 2021
@doeg doeg deleted the sarabee-vtadmin-select branch March 1, 2021 00:51
@doeg doeg added this to In progress in VTAdmin via automation Mar 16, 2021
@doeg doeg moved this from In progress to Done in VTAdmin Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants