Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing: Add vtctl fuzzer #7605

Merged
merged 1 commit into from Mar 5, 2021
Merged

Fuzzing: Add vtctl fuzzer #7605

merged 1 commit into from Mar 5, 2021

Conversation

AdamKorcz
Copy link
Contributor

Description

This PR adds a fuzzer for vtctl. The fuzzer is only meant to be run through OSS-fuzz for now.
A dictionary is added as well and the necessary changes are made in the build script.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@AdamKorcz AdamKorcz requested a review from deepthi as a code owner March 4, 2021 16:22
@AdamKorcz AdamKorcz marked this pull request as draft March 4, 2021 17:11
@AdamKorcz
Copy link
Contributor Author

@deepthi @systay Could you take a look here?
The fuzzer should not disturb the end-to-end tests and a build comment has been added as well.

go/vt/vtctl/vtctl_fuzzer.go Outdated Show resolved Hide resolved
go/vt/vtctl/vtctl_fuzzer.go Outdated Show resolved Hide resolved
go/vt/vtctl/vtctl_fuzzer.go Outdated Show resolved Hide resolved
Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz
Copy link
Contributor Author

AdamKorcz commented Mar 4, 2021

@deepthi Thank you for the comments. Do you think I could kindly ask you to check out the single failing test?

The tests now pass.

@AdamKorcz AdamKorcz marked this pull request as ready for review March 5, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants