Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add comments + 'options' parameter to API hooks #7754

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Mar 27, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

A tiny bit of janitorial work pulled out of the demo branch.

This updates vtadmin-web's API hooks to:

  • Add a passthrough for react-query options, which are not used yet (I know, I know) but establish a pattern that will be used in the future, starting with workflows.
  • Clean up types
  • Add a bit of commentary

Related Issue(s)

N/A

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m!

@rohit-nayak-ps rohit-nayak-ps merged commit 13e7372 into vitessio:master Mar 28, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Apr 1, 2021
@askdba askdba added this to the v10.0 milestone Apr 1, 2021
@ajm188 ajm188 added this to In progress in VTAdmin via automation May 21, 2021
@ajm188 ajm188 moved this from In progress to Done in VTAdmin May 21, 2021
@doeg doeg deleted the sarabee-vtadmin-web-hooks-nits branch November 1, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants