[vtadmin-web] Add hooks + skeleton view for workflows #7762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
approved these changes
Mar 30, 2021
| <tr key={idx}> | ||
| <td>{workflow?.name}</td> | ||
| <td>{cluster?.name}</td> | ||
| <td>{workflow?.source?.keyspace || '-'}</td> |
There was a problem hiding this comment.
I wonder if - is the right placeholder here, because in vitess that could be confused with the 00-00 shard
There was a problem hiding this comment.
Ohhh good idea, thanks! I updated it to "n/a" for now, which is straightforward but also lame. I'll get Shannon's thoughts on a better placeholder this week as we go over the rest of the UI.
| east: { | ||
| workflows: [ | ||
| { | ||
| workflow: { name: 'one-goes-east' }, |
There was a problem hiding this comment.
🤌 (cmon github, how is this not in your emoji set yet???)
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
|
Addressed feedback (thanks!) and also had a commit with actually correct sort order that I hadn't pushed up (sigh). |
ajm188
approved these changes
Mar 30, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/api/workflowsendpoint/workflowsview as a placeholder for later.Related Issue(s)
N/A
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: