Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with reserved connections to stale tablets #7879

Merged
merged 22 commits into from
Apr 22, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Apr 16, 2021

Description

Make sure to reconnect reserved connections to tablets that are not answering any more.

Related Issue(s)

Fixes #7875

Checklist

  • Should this PR be backported? Yes!
  • Tests were added or are not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

harshit-gangal and others added 3 commits April 16, 2021 10:47
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay and others added 4 commits April 16, 2021 10:30
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ceived

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… traffic and also has valid target

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… and were needed to be in sync

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ent tablet is not servicable without querying the tablet and using heathcheck at vtgate

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…query service connection if it matches the criteria

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…changed

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review April 19, 2021 18:58
harshit-gangal and others added 4 commits April 20, 2021 10:46
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal requested review from sougou and removed request for deepthi, shlomi-noach and harshit-gangal April 20, 2021 17:11
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of nits

go/vt/discovery/healthcheck.go Outdated Show resolved Hide resolved
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vtgate enable_system_settings reserved connections do not respect re-mastering
3 participants